Skip to content

Commit 24347f9

Browse files
joaquimgblegat
andauthored
Apply suggestions from code review
Co-authored-by: Benoît Legat <benoit.legat@gmail.com>
1 parent 3f99585 commit 24347f9

File tree

5 files changed

+4
-6
lines changed

5 files changed

+4
-6
lines changed

Project.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
1414
MathOptSetDistances = "3b969827-a86c-476c-9527-bb6f1a8fbad5"
1515
ParametricOptInterface = "0ce4ce61-57bf-432b-a095-efac525d185e"
1616
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
17-
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
1817

1918
[compat]
2019
BlockDiagonals = "0.1"

docs/src/manual.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ and the following objective types:
2828

2929
## Supported objectives & constraints - `ConicProgram` backend
3030

31-
For the `ConicProgram` backend backend, the package supports following `Function-in-Set` constraints:
31+
For the `ConicProgram` backend, the package supports following `Function-in-Set` constraints:
3232

3333
| MOI Function | MOI Set |
3434
|:-------|:---------------|

src/bridges.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ end
4747
function MOI.set(
4848
model::MOI.ModelLike,
4949
attr::ForwardConstraintFunction,
50-
bridge::MOI.Bridges.Constraint.ScalarizeBridge{T},
50+
bridge::MOI.Bridges.Constraint.ScalarizeBridge,
5151
value,
52-
) where {T}
52+
)
5353
MOI.set.(model, attr, bridge.scalar_constraints, value)
5454
return
5555
end

src/moi_wrapper.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ function diff_optimizer(
3939
# For this reason we add a cache layer, the same cache JuMP adds.
4040
caching_opt = if with_cache
4141
MOI.Utilities.CachingOptimizer(
42-
MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}()),
42+
MOI.Utilities.UniversalFallback(MOI.Utilities.Model{with_bridge_type}()),
4343
optimizer,
4444
)
4545
else

test/Project.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ SCS = "c946c3f1-0d1f-5ce8-9dea-7daa1f7e2d13"
1616
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
1717
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
1818
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
19-
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
2019

2120
[compat]
2221
HiGHS = "1"

0 commit comments

Comments
 (0)