Skip to content

Commit 91865cf

Browse files
committed
add suggestion
1 parent 24347f9 commit 91865cf

File tree

3 files changed

+10
-23
lines changed

3 files changed

+10
-23
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ IterativeSolvers = "0.9"
2222
JuMP = "1"
2323
LazyArrays = "0.21, 0.22, 1"
2424
MathOptInterface = "1.18"
25-
MathOptSetDistances = "0.2.7"
25+
MathOptSetDistances = "0.2.9"
2626
ParametricOptInterface = "0.9.0"
2727
julia = "1.6"

src/moi_wrapper.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ function diff_optimizer(
3939
# For this reason we add a cache layer, the same cache JuMP adds.
4040
caching_opt = if with_cache
4141
MOI.Utilities.CachingOptimizer(
42-
MOI.Utilities.UniversalFallback(MOI.Utilities.Model{with_bridge_type}()),
42+
MOI.Utilities.UniversalFallback(
43+
MOI.Utilities.Model{with_bridge_type}(),
44+
),
4345
optimizer,
4446
)
4547
else

src/parameters.jl

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -76,22 +76,22 @@ function SensitivityData{T}() where {T}
7676
)
7777
end
7878

79+
const _SENSITIVITY_DATA = :_sensitivity_data
80+
7981
function _get_sensitivity_data(
8082
model::POI.Optimizer{T},
8183
)::SensitivityData{T} where {T}
8284
_initialize_sensitivity_data!(model)
83-
return model.ext[:_sensitivity_data]::SensitivityData{T}
85+
return model.ext[_SENSITIVITY_DATA]::SensitivityData{T}
8486
end
8587

8688
function _initialize_sensitivity_data!(model::POI.Optimizer{T}) where {T}
87-
if !haskey(model.ext, :_sensitivity_data)
88-
model.ext[:_sensitivity_data] = SensitivityData{T}()
89+
if !haskey(model.ext, _SENSITIVITY_DATA)
90+
model.ext[_SENSITIVITY_DATA] = SensitivityData{T}()
8991
end
9092
return
9193
end
9294

93-
const DoubleDictInner = MOI.Utilities.DoubleDicts.DoubleDictInner
94-
9595
# forward mode
9696

9797
function _constraint_set_forward!(
@@ -280,7 +280,7 @@ end
280280

281281
function empty_input_sensitivities!(model::POI.Optimizer{T}) where {T}
282282
empty_input_sensitivities!(model.optimizer)
283-
model.ext[:_sensitivity_data] = SensitivityData{T}()
283+
model.ext[_SENSITIVITY_DATA] = SensitivityData{T}()
284284
return
285285
end
286286

@@ -304,21 +304,6 @@ function forward_differentiate!(model::POI.Optimizer{T}) where {T}
304304
return
305305
end
306306

307-
# function MOI.set(
308-
# model::POI.Optimizer,
309-
# ::ForwardParameter,
310-
# variable::MOI.VariableIndex,
311-
# value::Number,
312-
# )
313-
# if _is_variable(model, variable)
314-
# error("Trying to set a forward parameter sensitivity for a variable")
315-
# end
316-
# parameter = variable
317-
# sensitivity_data = _get_sensitivity_data(model)
318-
# sensitivity_data.parameter_input_forward[parameter] = value
319-
# return
320-
# end
321-
322307
function MOI.set(
323308
model::POI.Optimizer,
324309
::ForwardConstraintSet,

0 commit comments

Comments
 (0)