Add error for missing starting value #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquimg
approved these changes
Jan 12, 2025
* [WIP] Integrate with POI to improve UX * add missing import * temp change to proj toml * format * simplify method setting to sue model constructor * add possible fix to scalarize bridge error * add pkg to project * format * improvements * remove jump wrapper * clean tests * fix readme * use intermediary API * format * Apply suggestions from code review Co-authored-by: Benoît Legat <benoit.legat@gmail.com> * add suggestion * use Parameter set * todo was fixed * format * update docs for newer Flux * format * kwargs * remove diff model * suggestions * format * fix examples --------- Co-authored-by: Benoît Legat <benoit.legat@gmail.com>
…t.jl into bl/conic_missing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 85.38% 86.67% +1.29%
==========================================
Files 12 13 +1
Lines 1156 1478 +322
==========================================
+ Hits 987 1281 +294
- Misses 169 197 +28 ☔ View full report in Codecov by Sentry. |
andrewrosemberg
pushed a commit
to andrewrosemberg/DiffOpt.jl
that referenced
this pull request
Feb 5, 2025
joaquimg
added a commit
that referenced
this pull request
Feb 21, 2025
* NonLinearProgram * index by MOI index * only cache gradient * update API * start reverse mode * add overloads * update MOI wrapper * update code for DiffOpt API * working code * usage example * add reverse diff * update code * update tests * update tests * add forward_differentiate! tests * add reverse_differentiate! tests * update docs * format * update API reference * fix typos * update reference * update spdiagm * Typo "acutal" to "actual" (#258) Correcting typo "acutal" to "actual" * Fix GitHub actions badge in README (#263) * Implement MOI.Utilities.scalar_type for (Matrix|Sparse)VectorAffineFunction (#264) * Use SlackBridgePrimalDualStart (#253) * Use SlackBridgePrimalDualStart * Update src/copy_dual.jl * Remove test_broken * Add supports * Add comment * Move to AbstractModel * Integrate with POI to improve UX (#262) * [WIP] Integrate with POI to improve UX * add missing import * temp change to proj toml * format * simplify method setting to sue model constructor * add possible fix to scalarize bridge error * add pkg to project * format * improvements * remove jump wrapper * clean tests * fix readme * use intermediary API * format * Apply suggestions from code review Co-authored-by: Benoît Legat <benoit.legat@gmail.com> * add suggestion * use Parameter set * todo was fixed * format * update docs for newer Flux * format * kwargs * remove diff model * suggestions * format * fix examples --------- Co-authored-by: Benoît Legat <benoit.legat@gmail.com> * Add error for missing starting value (#269) * update API * expose kwargs * restrict hessian type * reverse wrong change * update usage * fix mad merge * fix typo * fix typo * fix wrong index * reverse index * allow user to just set relevat sensitivities * fix copy reverse sensitivity dual * format * update tests * format * update docs * extend parameter @test_throws tests for NLP * update comments * update private api: _add_leq_geq * fix typo * continue fix typo check asserts * expose factorization through as MOI.AbstractModelAttribute * add tests factorization * add comment * rm rm kwargs * use correct underscore signature for private funcs * format * change github actions to v3 * reverse checkout version * add reference sipopt paper * update factorization routine API * format * Update ci.yml * improve coverage * add test inertia correction * add test ReverseConstraintDual * format * rm useless checks * add test get ReverseConstraintDual * format * rm unecessary funcs * rm kwargs * format * rename factorization attributte * add supports * Apply suggestions from code review --------- Co-authored-by: mzagorowska <7868389+mzagorowska@users.noreply.github.com> Co-authored-by: Oscar Dowson <odow@users.noreply.github.com> Co-authored-by: Benoît Legat <benoit.legat@gmail.com> Co-authored-by: Joaquim <joaquimdgarcia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was useful when debugging #253