Fix conic error #284
Merged
Fix conic error #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [docs] update to Documenter@1 * Update
andrewrosemberg
commented
Apr 12, 2025
Comment on lines
+136
to
+138
| # FIXME: this is not working - https://github.com/jump-dev/DiffOpt.jl/issues/283 | ||
| # @test JuMP.coefficient(MOI.get(model, DiffOpt.ReverseConstraintFunction(), csoc).func.func.func, t.index) ≈ ds atol=ATOL rtol=RTOL | ||
|
|
There was a problem hiding this comment.
No clear API: #283
There was a problem hiding this comment.
this will be left open for a future PR
andrewrosemberg
commented
Apr 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jg/jumpapi #284 +/- ##
==============================================
+ Coverage 89.08% 89.43% +0.35%
==============================================
Files 15 16 +1
Lines 1969 1997 +28
==============================================
+ Hits 1754 1786 +32
+ Misses 215 211 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <joaquimdgarcia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug in the conic formulation in which forward sensitivities with LHS have flipped the sign.
Related to how the
dAmatrix of sensitivities is used.TODO:
ReverseConstraintFunctionfor Conic Constraints #283DiffOpt.forward_differentiate!from PSD Conic JuMP problems #285