Skip to content

Update with v12.0.0 libraries #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Update with v12.0.0 libraries #27

merged 10 commits into from
Nov 12, 2024

Conversation

torressa
Copy link
Collaborator

@torressa torressa commented Oct 2, 2024

  • Update conda URLs
  • Update archive checksums
  • Update tree checksums
  • Update libs
  • Update tests
  • Remove open_documentation command (12.0 no longer ships the documentation)
  • Update README (OSS licenses are in a different location in the conda packages)

@simonbowly
Copy link
Collaborator

@torressa I rebased your PR and updated the artifacts for 12.0.0.

@odow I think this is ready to go? One notable change though is that the open_documentation command had to go away. The docs are not contained in the conda packages anymore.

@simonbowly simonbowly requested a review from odow November 12, 2024 05:43
@simonbowly simonbowly marked this pull request as ready for review November 12, 2024 05:43
error = @ccall libgurobi.GRBemptyenv(envptr::Ptr{Ptr{Cvoid}})::Cint
# Temporary workaround for 12.0.0. This can be reverted to use GRBemptyenv for 12.0.1
# https://docs.gurobi.com/projects/optimizer/en/12.0/reference/releasenotes/knownbugs.html
error = @ccall libgurobi.GRBemptyenvinternal(envptr::Ptr{Ptr{Cvoid}}, 12::Int, 0::Int, 0::Int)::Cint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this passed your testing?

This is a blocker for adoption in Gurobi.jl:

https://github.com/jump-dev/Gurobi.jl/blob/52ca3d9292804e0eea8f7f4e1a55eb517898c600/src/MOI_wrapper/MOI_wrapper.jl#L107

Can't you just release 12.0.1 immediately? I don't see the point in releasing this version if it can't be used without touching undocumented internals.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GRBemptyenv is exposed via a header define. The majority of users don't need the internal function.

Can you clarify why it's a blocker here? libgrb_api.jl has the necessary additions, picked up automatically from the header files:

https://github.com/jump-dev/Gurobi.jl/blob/52ca3d9292804e0eea8f7f4e1a55eb517898c600/src/gen120/libgrb_api.jl#L4645-L4652

We've been testing Gurobi.jl with 12 already, and this doesn't appear to be a problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't look for the header change. So this is a problem only for this particular test in Gurobi_jll.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@odow odow merged commit c07c102 into jump-dev:master Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants