-
Notifications
You must be signed in to change notification settings - Fork 3
Update with v12.0.0 libraries #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Call GRBemptyenvinternal with the technical version number
error = @ccall libgurobi.GRBemptyenv(envptr::Ptr{Ptr{Cvoid}})::Cint | ||
# Temporary workaround for 12.0.0. This can be reverted to use GRBemptyenv for 12.0.1 | ||
# https://docs.gurobi.com/projects/optimizer/en/12.0/reference/releasenotes/knownbugs.html | ||
error = @ccall libgurobi.GRBemptyenvinternal(envptr::Ptr{Ptr{Cvoid}}, 12::Int, 0::Int, 0::Int)::Cint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this passed your testing?
This is a blocker for adoption in Gurobi.jl:
Can't you just release 12.0.1 immediately? I don't see the point in releasing this version if it can't be used without touching undocumented internals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GRBemptyenv
is exposed via a header define. The majority of users don't need the internal function.
Can you clarify why it's a blocker here? libgrb_api.jl has the necessary additions, picked up automatically from the header files:
We've been testing Gurobi.jl with 12 already, and this doesn't appear to be a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't look for the header change. So this is a problem only for this particular test in Gurobi_jll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
open_documentation
command (12.0 no longer ships the documentation)