Skip to content

[Nonlinear] fix _UnsafeVectorView with ForwardDiff@1.0.0 #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2025

Conversation

odow
Copy link
Member

@odow odow commented Apr 3, 2025

ForwardDiff@1 changed to use CartesianIndex, which we hadn't supported.

We also never tested this, because we tested only that the operator could be called, but never end-to-end through the ReverseAD system. Nasty.

https://github.com/jump-dev/MathOptInterface.jl/actions/runs/14232574450

@odow odow mentioned this pull request Apr 3, 2025
5 tasks
@odow
Copy link
Member Author

odow commented Apr 3, 2025

@odow
Copy link
Member Author

odow commented Apr 3, 2025

There's a surprising amount of nuance in this.

@odow odow merged commit a020b50 into master Apr 3, 2025
31 checks passed
@odow odow deleted the od/fix-forward-diff branch April 3, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant