Skip to content

Allow using Test.runtests in other packages #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Allow using Test.runtests in other packages #2710

merged 2 commits into from
Apr 8, 2025

Conversation

blegat
Copy link
Member

@blegat blegat commented Apr 4, 2025

Would be useful for blegat/LowRankOpt.jl#6 for instance

@odow
Copy link
Member

odow commented Apr 4, 2025

I'm not necessarily for or against this. One massive downside is that we'd be committing to the API Innside this function. I don't know that it's worth it to save a single package (LowRankOpt) copy-pasting a single function. Especially if the long-term goal is to merge some form of LowRankOpt back into MOI.

@blegat
Copy link
Member Author

blegat commented Apr 7, 2025

I was wondering about how much more we're committing to if the API (name of the function, name of the keywords, behavior) is already public anyway. What would be breaking for a use of test_module that wouldn't be also breaking now anyway ?

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this if https://github.com/jump-dev/MathOptInterface.jl/actions/runs/14327216427 looks okay

(Edit: it's going to look bad for the solvers with secrets because this branch isn't rebased on the latest master.)

@odow odow merged commit df498f5 into master Apr 8, 2025
81 of 91 checks passed
@odow odow deleted the bl/test_mod branch April 8, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants