Skip to content

Prep for v1.40.0 #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2025
Merged

Prep for v1.40.0 #2743

merged 3 commits into from
May 4, 2025

Conversation

odow
Copy link
Member

@odow odow commented Apr 30, 2025

TODO

Basic

  • version field of Project.toml has been updated
    - If a breaking change, increment the MAJOR field and reset others to 0
    - If adding new features, increment the MINOR field and reset PATCH to 0
    - If adding bug fixes or documentation changes, increment the PATCH field

Documentation

  • Add a new entry to docs/src/changelog.md, following existing style

Tests

@odow
Copy link
Member Author

odow commented Apr 30, 2025

@blegat a bunch of solver-test failures from your ReverseAD changes. I'll take a look this afternoon.

@odow odow requested a review from blegat May 2, 2025 01:31
@blegat
Copy link
Member

blegat commented May 2, 2025

Clarabel is failing its native optimizer tests and it was already failing at the last release so it's fine (it's also been reported oxfordcontrol/Clarabel.jl#198)
For BilevelJuMP, it was working at the last release so did we break it ? #2719

@odow
Copy link
Member Author

odow commented May 2, 2025

I think BilevelJuMP is just a flakey test because @joaquimg sets a time limit of 5 seconds. I guess a big portion of that is precompilation.

@joaquimg
Copy link
Member

joaquimg commented May 3, 2025

I will look into it.

@odow
Copy link
Member Author

odow commented May 4, 2025

Ah. It'll be because I'm not precompiling a solve that uses ReverseAD in Ipopt: https://github.com/jump-dev/Ipopt.jl/blob/0acb50a719db990fc5529743d44e7b5fa59c1ef6/ext/IpoptMathOptInterfaceExt/IpoptMathOptInterfaceExt.jl#L21-L77

@odow odow merged commit 86bfa1d into master May 4, 2025
31 checks passed
@odow odow deleted the od/v1.40.0 branch May 4, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants