Skip to content

Implement adjacency_matrix and expression in _FunctionStorage #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

blegat
Copy link
Member

@blegat blegat commented May 9, 2025

EAGO is accessing the objective and constraints fields of ReverseAD.NLPEvaluator which is ok since it's not starting with a _.
But then it is accessing internal fields of _FunctionStorage and _SubexpressionStorage which it shouldn't since these start with an _.
Actually, all they need are the nodes and const_values which are part of MOI.Nonlinear.Expression and the adjacency matrix so by implementing adjacency_matrix and adding a expression function that it implements, it allows EAGO to stop using internal fields and stick to the public API.

See the corresponding EAGO PR here : PSORLab/EAGO.jl#147

@odow
Copy link
Member

odow commented May 9, 2025

I'd prefer we just closed #2747

@odow
Copy link
Member

odow commented May 10, 2025

Close this as well?

@blegat
Copy link
Member Author

blegat commented May 10, 2025

Yes, let's close

@blegat blegat closed this May 10, 2025
@odow odow deleted the bl/expression_adj branch May 10, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants