Implement adjacency_matrix and expression in _FunctionStorage #2750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EAGO is accessing the
objective
andconstraints
fields ofReverseAD.NLPEvaluator
which is ok since it's not starting with a_
.But then it is accessing internal fields of
_FunctionStorage
and_SubexpressionStorage
which it shouldn't since these start with an_
.Actually, all they need are the
nodes
andconst_values
which are part ofMOI.Nonlinear.Expression
and the adjacency matrix so by implementingadjacency_matrix
and adding aexpression
function that it implements, it allows EAGO to stop using internal fields and stick to the public API.See the corresponding EAGO PR here : PSORLab/EAGO.jl#147