Skip to content

Allow changing coefficient type in FileFormats.Model #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow changing coefficient type in FileFormats.Model #2532

wants to merge 1 commit into from

Conversation

blegat
Copy link
Member

@blegat blegat commented Aug 7, 2024 •
edited
Loading

@blegat blegat mentioned this pull request Aug 7, 2024
Merged
1 task
@odow
Copy link
Member

odow commented Aug 8, 2024

I wonder if this should be value_type: https://jump.dev/JuMP.jl/stable/api/JuMP/#value_type

@odow
Copy link
Member

odow commented Aug 8, 2024

I don't think we should add this. Many file formats do not support non-Float64 number types, and SDPA already has a number_type argument:

MathOptInterface.jl/src/FileFormats/SDPA/SDPA.jl

Line 57 in b5659b5

Model(; number_type::Type = Float64)

This is also not needed for JuMP: jump-dev/JuMP.jl#3801 (comment)

@odow
Copy link
Member

odow commented Aug 8, 2024

The correct solution is probably to standardize on a value_type kwarg where file formats support it.

@blegat blegat closed this Aug 8, 2024
@odow odow deleted the bl/file_format_T branch August 8, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegat @odow