VectorQuadraticFunction constructor #2633
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not keep the existing implementation ? |
Co-authored-by: Joaquim <joaquimdgarcia@gmail.com>
Co-authored-by: Joaquim <joaquimdgarcia@gmail.com>
I find the loop version simpler instead of having to mapreduce multiple times over the same vector |
joaquimg
reviewed
Feb 17, 2025
Comment on lines
+685
to
+689
| ret = VectorQuadraticFunction{T}( | ||
| VectorQuadraticTerm{T}[], | ||
| VectorAffineTerm{T}[], | ||
| T[], | ||
| ) |
There was a problem hiding this comment.
I mentioned in the other PR also:
If this constructor is just for testing purposes and manually building constraints, I would be okay with the simple loop.
But, vectorize is used in bridges in potentially large problems.
Hence, we need, at least, some sizehint!s arounds
|
Closing in favor of #2636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same vein as #2626