Add bridge from Hermitian PSD to complex function in Symmetric PSD #2724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jump-dev/SeDuMi.jl#28 (comment)
Basic
src/Bridges/XXX/bridges
named after the type ofthe bridge
struct must end in
Bridge
MOI.Bridges.Constraint.SetMapBridge
const
that is aSingleBridgeOptimizer
wrapping thenew bridge. The name of the const must be the name of the bridge, less
the
Bridge
suffixadd_all_bridges
at the bottom ofsrc/Bridges/XXX/XXX.jl
Tests
tests/Bridges/XXX
named after the type of the bridge
MOI.Bridges.runtests
to test various inputs and outputs of thebridge
covered by the tests, add additional bridge-specific tests to cover the
untested lines.
Documentation
Final touch
If the bridge depends on run-time values of other variables and constraints in
the model:
MOI.Utilities.needs_final_touch(::Bridge)
MOI.Utilities.final_touch(::Bridge, ::MOI.ModelLike)
final_touch
can be called multiple times in a row