Skip to content

Use throw_if_scalar_and_constant_not_zero when appropriate #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2025
Merged

Use throw_if_scalar_and_constant_not_zero when appropriate #2753

merged 2 commits into from
May 10, 2025

Conversation

blegat
Copy link
Member

@blegat blegat commented May 10, 2025

I think these lines were written before that helper existed

blegat
blegat commented May 10, 2025
View reviewed changes
@odow odow merged commit 4e26305 into master May 10, 2025
31 checks passed
@odow odow deleted the bl/throw_if_scalar_not_zero branch May 10, 2025 21:47
@sourcery-ai sourcery-ai bot mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegat @odow