-
Notifications
You must be signed in to change notification settings - Fork 8
Add time limits to compute ideal point & dichotomy starting solutions #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
with 0 timelimit, there should be no solutions as there is no solve.
A time limit too small for the ideal point computation will probably also be too small to generate any nondominated points, right? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 99.07% 98.77% -0.31%
==========================================
Files 9 9
Lines 974 980 +6
==========================================
+ Hits 965 968 +3
- Misses 9 12 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
Yeah, I think that would be the case in general. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll merge this once CI runs.
Hi,
This PR adds time limits to solving for ideal points, and the first solves of the dichotomy algorithm.
I realise that timing-out when solving for ideal points indicates that the time limit is probably way to small to get anything meaningful from the multi-objective formulation, but this was an edge case I faced, leading to some behaviour I was not expecting.
Also, this brings this package more in line with other MO solvers. For instance if I just used Gurobi to solve the multi-objective function, then for sure I would expect it to satisfy my time limit. But currently with this package the solver could go far beyond my time limit. For example, the start time before computation of ideal points is not passed down to any of the algorithms, so if it takes a long time to solve for ideal points, and the lower algorithm times out, then the overall solve time could be significantly more than the users time limit. But I haven't touched this because I users can now turn off ideal point calculation.
Hopefully that makes sense.
Finally, the logic before the 0 time limit unit-test for the dichotomy algorithm doesn't make sense to me. If the user provided a time limit of 0, then I would expect there to be no solutions returned?
Thanks for the package :)