Fix margin-bottom for ul tags (#157)

odow · web-flow · commit 9cc3c3e6c14f · 2024-09-09T16:28:04.000+12:00
diff --git a/assets/styles.scss b/assets/styles.scss
@@ -74,16 +74,18 @@ $colour-notification-banner: #ffc107;
     font-size: 100%;
   }
 }
+
 // Over-ride default indentation.
 :root {
   p{
     margin-bottom: 0rem;
   }
   ul{
-    // TODO(odow): we should reduce the margin-bottom of lists, except this
-    // disables the drop-down navigation button on mobile.
-    // margin-bottom: 0rem;
     margin-left: 1em;
+    margin-bottom: 0;
+  }
+  .list--nav {
+    margin-bottom: var(--listHeight, 0)
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -74,16 +74,18 @@ $colour-notification-banner: #ffc107;`
`74`	`74`	`font-size: 100%;`
`75`	`75`	`}`
`76`	`76`	`}`
	`77`	`+`
`77`	`78`	`// Over-ride default indentation.`
`78`	`79`	`:root {`
`79`	`80`	`p{`
`80`	`81`	`margin-bottom: 0rem;`
`81`	`82`	`}`
`82`	`83`	`ul{`
`83`		`- // TODO(odow): we should reduce the margin-bottom of lists, except this`
`84`		`- // disables the drop-down navigation button on mobile.`
`85`		`- // margin-bottom: 0rem;`
`86`	`84`	`margin-left: 1em;`
	`85`	`+ margin-bottom: 0;`
	`86`	`+ }`
	`87`	`+ .list--nav {`
	`88`	`+ margin-bottom: var(--listHeight, 0)`
`87`	`89`	`}`
`88`	`90`	`}`
`89`	`91`