Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when deleting symlinks that point outside temp dir #4303

Closed
2 tasks done
marcphilipp opened this issue Feb 7, 2025 · 5 comments · Fixed by #4306
Closed
2 tasks done

Warn when deleting symlinks that point outside temp dir #4303

marcphilipp opened this issue Feb 7, 2025 · 5 comments · Fixed by #4306

Comments

@marcphilipp
Copy link
Member

marcphilipp commented Feb 7, 2025

This is a follow-up on a discussion we had about #4301.

Deliverables

  • Document that symlinks in temp dirs are deleted but not their targets (if they reside outside of the temp dir)
  • Log a warning for every symlink that is deleted but points to a target outside the temp dir
@YongGoose
Copy link
Contributor

@marcphilipp

I understand that version 5.12.0-RC2 is scheduled for release this Friday.
Since there are no contributors, it could delay your timeline, I’d like to help resolve this issue as quickly as possible if I can. 🚀

Additionally, could you provide any additional information that might help in addressing this issue?

@marcphilipp
Copy link
Member Author

marcphilipp commented Feb 10, 2025

Thanks for the offer! However, it's already done in my head (meaning that I "only need to write it down") and since, as you've pointed out, we don't want this to delay the release, I'll take a stab myself. I should probably have assigned myself right away.

@YongGoose
Copy link
Contributor

Thanks for the offer! However, it's already done in my head (meaning that I "only need to write it down") and since, as you've pointed out, we don't want this to delay the release, I'll take a stab myself. I should probably have assigned myself right away.

Not at all!

I really appreciate how much you care about the community.
I have no doubt that your decision is the best choice for the JUnit 5 project.

I will focus on the work I'm currently working on.

I've learned a lot thanks to you.
Looking forward to your amazing work! 🚀

@marcphilipp
Copy link
Member Author

You're welcome to review #4306, though, if you're interested! 🙂

@YongGoose
Copy link
Contributor

You're welcome to review #4306, though, if you're interested! 🙂

Thank you for the opportunity!
I'll review it now. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants