feat: change how the project is organized and release an alpha version #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willianantunes
added
the
[type] enhancement: not planned
willianantunes
requested review from
leticiasassaki,
NewtonRocha,
fabioalmeida100,
fabiohk,
jeosadache and
abxsantos
willianantunes
force-pushed
the
feat/change-project-structure
branch
4 times, most recently
from
c94b8b8 to
18138cd
Compare
willianantunes
added
documentation
willianantunes
changed the title
willianantunes
force-pushed
the
feat/change-project-structure
branch
3 times, most recently
from
587c2a1 to
c67603a
Compare
willianantunes
force-pushed
the
feat/change-project-structure
branch
4 times, most recently
from
9d25d26 to
987edb9
Compare
- Remove library `JSM.PartialJsonObject`. - Update Dockerfile. - Format some files given `docker compose up lint-formatter` execution. - Use net8.0 in all projects. - Remove `wait-for-it.sh` and use healthcheck in sqlserver service.
willianantunes
force-pushed
the
feat/change-project-structure
branch
from
987edb9 to
3335436
Compare
willianantunes
force-pushed
the
feat/change-project-structure
branch
from
3335436 to
59cf6dc
Compare
rafaelpadovezi
previously approved these changes
Sep 16, 2024
tests/AspNetCore.RestFramework.Core.Test/Support/IntegrationTestBase.cs
Outdated
Show resolved
Hide resolved
- Add `Microsoft.AspNetCore.Mvc.NewtonsoftJson`. - `NewtonsoftJson` is required by the framework. - Use a new database for each test method to avoid race condition. - Use SqlServer instead of InMemory database
willianantunes
force-pushed
the
feat/change-project-structure
branch
from
59cf6dc to
ec4bb65
Compare
|
ricardochaves
approved these changes
Sep 16, 2024
rafaelpadovezi
approved these changes
Sep 16, 2024
leticiasassaki
approved these changes
Sep 16, 2024
willianantunes
changed the title
willianantunes
added a commit
that referenced
this pull request
Sep 17, 2024
* chore: change how projects are organized - Remove library `JSM.PartialJsonObject`. - Update Dockerfile. - Format some files given `docker compose up lint-formatter` execution. - Use net8.0 in all projects. - Remove `wait-for-it.sh` and use healthcheck in sqlserver service. * feat: remove sample project and configure tests - Add `Microsoft.AspNetCore.Mvc.NewtonsoftJson`. - `NewtonsoftJson` is required by the framework. - Use a new database for each test method to avoid race condition. - Use SqlServer instead of InMemory database * docs: add license file * chore(nuget): enable repeatable package restores using a lock file Know more at: - https://bit.ly/3QnsqTU * chore(ci/cd): add actions for pr, coverage, and package publication * chore: add project metadata * test: improve coverage * docs: translate readme to en-us and change some statements
willianantunes
added a commit
that referenced
this pull request
Sep 17, 2024
* chore: change how projects are organized - Remove library `JSM.PartialJsonObject`. - Update Dockerfile. - Format some files given `docker compose up lint-formatter` execution. - Use net8.0 in all projects. - Remove `wait-for-it.sh` and use healthcheck in sqlserver service. * feat: remove sample project and configure tests - Add `Microsoft.AspNetCore.Mvc.NewtonsoftJson`. - `NewtonsoftJson` is required by the framework. - Use a new database for each test method to avoid race condition. - Use SqlServer instead of InMemory database * docs: add license file * chore(nuget): enable repeatable package restores using a lock file Know more at: - https://bit.ly/3QnsqTU * chore(ci/cd): add actions for pr, coverage, and package publication * chore: add project metadata * test: improve coverage * docs: translate readme to en-us and change some statements * chore: rename actions * docs: organize readme following drf documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
What is being delivered?
I'm following what I said on Slack. I copied the structure of AspNetCore.Diagnostics.HealthChecks project and applied it into this project. The library
JSM.PartialJsonObjecthas been removed and its code has been included in the project.JSM.FluentValidation.AspNet.AsyncFilteris still in place. I plan to remove it in another opportunity.Some files have been updated because of the result of
docker compose up lint-formatter. Beyond it, everything is the same. Tests are running just fine.