Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add can-dismiss property to control modal dismissal #700

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

brunosf
Copy link
Contributor

@brunosf brunosf commented Feb 10, 2025

Infos

Task

What is being delivered?

  • Adds a new canDismiss property to control the ability to close the modal.
  • Adds a new idName property to use as a ref selector to differentiate teleported modals.

What impacts?

React | Vue | Core components

Reversal plan

Describe which plan we should follow if this delivery has to be reversed.

Evidences

Kooha-2025-02-12-14-22-20.mp4

Copy link
Contributor

github-actions bot commented Feb 10, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-12 20:22 UTC

Copy link

@brunosf brunosf marked this pull request as ready for review February 12, 2025 17:37
@brunosf brunosf merged commit 6b7640f into main Feb 12, 2025
5 checks passed
@brunosf brunosf deleted the feat/enable-can-dismiss-prop-atom-modal branch February 12, 2025 20:19
This was referenced Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants