Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linters): enable es2021 to lint #104

Merged
merged 3 commits into from
Jan 23, 2024
Merged

feat(linters): enable es2021 to lint #104

merged 3 commits into from
Jan 23, 2024

Conversation

SallesCosta
Copy link
Contributor

@SallesCosta SallesCosta commented Dec 22, 2023

Infos

Task

Issue with solution in Eslint repository

What is being delivered?

By adding es2021=true it will enable all of the ES2021 globals (such as Promise, Map, Set).

What impacts?

No side effects are expected with this addition.

Reversal plan

Revert this PR or removing the modification in packages/linters/src/eslint.config.js (line 6) and merge to master again.

Evidences

before
Captura de Tela 2023-12-22 às 16 40 39

after
Captura de Tela 2024-01-04 às 12 33 14

@SallesCosta SallesCosta self-assigned this Dec 22, 2023
@SallesCosta SallesCosta marked this pull request as ready for review January 4, 2024 11:34
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SallesCosta SallesCosta changed the title feat: enable es6 to lint feat: enable es2021 to lint Jan 10, 2024
@felipefialho felipefialho changed the title feat: enable es2021 to lint feat(linters): enable es2021 to lint Jan 10, 2024
Copy link
Contributor

@JulioCVaz JulioCVaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@SallesCosta SallesCosta merged commit 3b2721d into main Jan 23, 2024
2 checks passed
@SallesCosta SallesCosta deleted the feat/add-es6-true branch January 23, 2024 18:11
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation packages/linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants