Skip to content

Commit e35607f

Browse files
committed
add name, parameters fields to Workflow and WorkflowDefinition
1 parent 87306a8 commit e35607f

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

jupyter_scheduler/orm.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ class Workflow(Base):
116116
tasks = Column(JsonType)
117117
status = Column(String(64), default=Status.CREATED)
118118
active = Column(Boolean, default=False)
119+
name = Column(String(256))
120+
parameters = Column(JsonType(1024))
119121
# All new columns added to this table must be nullable to ensure compatibility during database migrations.
120122
# Any default values specified for new columns will be ignored during the migration process.
121123

@@ -129,6 +131,8 @@ class WorkflowDefinition(Base):
129131
active = Column(Boolean, default=False)
130132
schedule = Column(String(256))
131133
timezone = Column(String(36))
134+
name = Column(String(256))
135+
parameters = Column(JsonType(1024))
132136
# All new columns added to this table must be nullable to ensure compatibility during database migrations.
133137
# Any default values specified for new columns will be ignored during the migration process.
134138

jupyter_scheduler/workflows.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import json
2-
from typing import List, Optional
2+
from typing import Dict, List, Optional
33

44
from jupyter_server.utils import ensure_async
55
from tornado.web import HTTPError, authenticated
@@ -291,9 +291,13 @@ async def post(self, workflow_definition_id: str):
291291

292292
class CreateWorkflow(BaseModel):
293293
tasks: List[str] = []
294+
name: str
295+
parameters: Optional[Dict[str, str]] = None
294296

295297

296298
class DescribeWorkflow(BaseModel):
299+
name: str
300+
parameters: Optional[Dict[str, str]] = None
297301
workflow_id: str
298302
tasks: List[str] = None
299303
status: Status = Status.CREATED
@@ -304,6 +308,8 @@ class Config:
304308

305309

306310
class UpdateWorkflow(BaseModel):
311+
name: str
312+
parameters: Optional[Dict[str, str]] = None
307313
tasks: Optional[List[str]] = None
308314
status: Optional[Status] = None
309315
active: Optional[bool] = None
@@ -315,6 +321,8 @@ class Config:
315321
class CreateWorkflowDefinition(BaseModel):
316322
tasks: List[str] = []
317323
# any field added to CreateWorkflow should also be added to this model as well
324+
name: str
325+
parameters: Optional[Dict[str, str]] = None
318326
schedule: Optional[str] = None
319327
timezone: Optional[str] = None
320328

@@ -323,6 +331,8 @@ class Config:
323331

324332

325333
class DescribeWorkflowDefinition(BaseModel):
334+
name: str
335+
parameters: Optional[Dict[str, str]] = None
326336
workflow_definition_id: str
327337
tasks: List[str] = None
328338
schedule: Optional[str] = None
@@ -335,6 +345,8 @@ class Config:
335345

336346

337347
class UpdateWorkflowDefinition(BaseModel):
348+
name: str
349+
parameters: Optional[Dict[str, str]] = None
338350
tasks: Optional[List[str]] = None
339351
schedule: Optional[str] = None
340352
timezone: Optional[str] = None

0 commit comments

Comments
 (0)