-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Drop support for Python 3.8 #7628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure how CI is set up, so this change might make some of the checks start using Python3.9, which could be the reason of |
Thanks @honnix for looking into this. It's probably because of |
Hi @jtpio . Thank you for the quick reply. I changed ruff config to ignore |
This is now good to go. I can follow this up fixing stuff using ruff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Makes sense to fix some of the ruff
rules in a follow-up PRs. Maybe some of them are not needed anymore?
That I don't know. I'm not familiar with the code base at all. |
Python 3.8 is no longer supported by notebook, so this lower bound needs to be changed.
$ pip3.8 index versions notebook WARNING: pip index is currently an experimental command. It may be removed/changed in a future release without prior warning. notebook (7.4.0)