Fix orthographic camera near and far parameters #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview PR at appsharing.space |
|
Integration tests report: appsharing.space |
martinRenou
changed the title
martinRenou
requested changes
May 20, 2025
| this._camera.updateProjectionMatrix(); | ||
| } | ||
| } | ||
| this._camera = new THREE.PerspectiveCamera( |
There was a problem hiding this comment.
I'm not sure why we're removing the check for the current camera setting?
| @@ -1075,6 +1054,8 @@ export class MainView extends React.Component<IProps, IStates> { | |||
| } else { | |||
| this._refLength = null; | |||
| } | |||
|
|
|||
| this._updateCamera(); | |||
There was a problem hiding this comment.
If possible, we shouldn't reset the camera entirely here (note we're already have some code in this method that updates some camera parameters).
Instead, we should only set the new near and far if it's an orthographic camera.
martinRenou
reviewed
May 20, 2025
Co-authored-by: martinRenou <martin.renou@gmail.com>
arjxn-py
commented
May 20, 2025
martinRenou
reviewed
May 28, 2025
Co-authored-by: martinRenou <martin.renou@gmail.com>
martinRenou
reviewed
May 28, 2025
Co-authored-by: martinRenou <martin.renou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall fix #742
orthographic.mp4
orth.mp4