pre-commit: add black, isort, pyupgrade, autoflake, flake8, and misc hooks #104
Conversation
consideRatio
force-pushed
the
pr/add-ruff-hook
branch
from
601b30c to
738a247
Compare
There was a problem hiding this comment.
I'm kinda wary of ruff given it's VC funding, and would prefer we use the same stack we use elsewhere instead (black, etc). Nothing against the people behind ruff specifically! If we want to introduce ruff into the jupyterhub project, I'd like there to be more community consensu before we do so.
|
Ah okay, we can go for the normal stuff - I adopted it after setting it be piloted for use in jupyterhub/jupyterhub |
consideRatio
force-pushed
the
pr/add-ruff-hook
branch
from
44c0462 to
6ad0a31
Compare
for more information, see https://pre-commit.ci
consideRatio
changed the title
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env jsonnet -J ../vendor | |||
| #!/usr/bin/env -S jsonnet -J ../vendor | |||
There was a problem hiding this comment.
I had to use -S to not have env parse the content above as a command with spaces in it.
| @@ -1,3 +1,4 @@ | |||
| #!/usr/bin/env -S jsonnet -J ../vendor | |||
There was a problem hiding this comment.
I had to ensure shebangs were added to executable files.
I removed the executable flag for the libsonnet file that renders blank anyhow.
|
@yuvipanda I'll go for a merge now to unblock myself to contribute further, I'll push a merge commit to your PR fixing the conflict caused by this as well |
This adds the usual hooks except prettier to this repo. I'm omitting prettier for now since I expect it could lead to merge conflicts with docs PRs #99.
This PR will have a probably quite simple to resolve merge conflict with #90.