Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom timeout not used by function #517

Open
jhgoebbert opened this issue Feb 24, 2025 · 0 comments
Open

custom timeout not used by function #517

jhgoebbert opened this issue Feb 24, 2025 · 0 comments
Labels

Comments

@jhgoebbert
Copy link

Bug description

The default timeout for a process to become ready can now be set as timeout.

This can now be configured here with a default value of 5s

    timeout = Int(
        5, help="Timeout in seconds for the process to become ready, default 5s."
    ).tag(config=True)

https://github.com/jupyterhub/jupyter-server-proxy/blob/main/jupyter_server_proxy/config.py#L110

but it is not used here

    def get_timeout(self):
        """
        Return timeout (in s) to wait before giving up on process readiness
        """
        return 5

https://github.com/jupyterhub/jupyter-server-proxy/blob/main/jupyter_server_proxy/handlers.py#L918

@jhgoebbert jhgoebbert added the bug label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant