Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Markdown table generation in magic commands #118

Open
JasonWeill opened this issue Apr 25, 2023 · 2 comments · May be fixed by #1243
Open

Simplify Markdown table generation in magic commands #118

JasonWeill opened this issue Apr 25, 2023 · 2 comments · May be fixed by #1243
Labels
enhancement New feature or request good first issue Good for newcomers @jupyter-ai/magics
Milestone
Future

Comments

@JasonWeill
Copy link
Collaborator

Problem

As @dlqqq noted in #100, in the results of %ai list, it may be possible to use libraries like py-markdown-table to generate markdown tables declaratively, based on a data structure, instead of imperatively, as we currently do. Some of our logic is declared twice, once for text and once for markdown format.

Proposed Solution

Use py-markdown-table, or a similar library, to generate markdown for the model list.

Use markdown-style tables for text output.

Remove remaining helper functions that use different logic for text and markdown parts.
@JasonWeill JasonWeill added the enhancement New feature or request label Apr 25, 2023
@dlqqq dlqqq mentioned this issue Apr 25, 2023
Merged
@JasonWeill JasonWeill added this to the Future milestone Jul 28, 2023
@dlqqq dlqqq changed the title In text, display model list in markdown table format Simplify code used to generate Markdown tables in magic commands Feb 4, 2025
@dlqqq dlqqq changed the title Simplify code used to generate Markdown tables in magic commands Simplify Markdown table generation in magic commands Feb 4, 2025
@dlqqq dlqqq added the good first issue Good for newcomers label Feb 4, 2025
@krassowski krassowski linked a pull request Feb 13, 2025 that will close this issue
Intial demo - ai list markdown table #1243
Draft
@dlqqq
Copy link
Member

dlqqq commented Feb 18, 2025

@keerthi-swarna is working on a fix for this in #1243. Mentioning Keerthi here so I can assign this issue to Keerthi.

@dlqqq
Copy link
Member

dlqqq commented Feb 18, 2025

Oh, actually I need to add Keerthi to the project before I can assign Keerthi an issue. I'll do that now.

Reference: https://stackoverflow.com/questions/41171882/how-to-assign-an-issue-to-non-contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers @jupyter-ai/magics
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Intial demo - ai list markdown table keerthi-swarna/jupyter-ai
2 participants
@dlqqq @JasonWeill