Upgrade dependencies; remove ember-data #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,6 @@ | |||
| "ember": "1.13.11", | |||
| "ember-cli-shims": "ember-cli/ember-cli-shims#0.0.3", | |||
| "ember-cli-test-loader": "ember-cli-test-loader#0.1.3", | |||
| "ember-data": "1.13.15", | |||
There was a problem hiding this comment.
I don't believe this is needed by this addon at all, but correct me if I'm wrong
|
Thanks for yet another PR! I had to run a few errands today, I will review the PR tomorrow. For the utils script, do you think it is probable to mock its existence by removing from and adding the library back to the global namespace, before compiling the templates? |
|
Where are we with this PR ? I think we should redo the upgrade since it's already been a year this PR is pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a basic integration test. I'd like to test more, but couldn't figure out how to optionally import the
intlTelInputUtilsin the test, upon which 90% of the functionality rests.