Merge pull request #35 from justwatch/fix/nil-pointer

joidegn · web-flow · commit 8a4ca60ad7b0 · 2024-10-12T06:39:26.000+02:00
Prevent nil pointer dereference
diff --git a/marketing/v19/adcreative.go b/marketing/v19/adcreative.go
@@ -298,7 +298,7 @@ func (ac AdCreative) GetLinkCaption() string {
 		return ""
 	}
 
-	if ac.ObjectStorySpec.LinkData != nil {
+	if ac.ObjectStorySpec.LinkData != nil && ac.ObjectStorySpec.LinkData.CallToAction != nil && ac.ObjectStorySpec.LinkData.CallToAction.Value != nil {
 		return ac.ObjectStorySpec.LinkData.CallToAction.Value.LinkCaption
 	} else if ac.ObjectStorySpec.VideoData != nil && ac.ObjectStorySpec.VideoData.CallToAction != nil && ac.ObjectStorySpec.VideoData.CallToAction.Value != nil {
 		return ac.ObjectStorySpec.VideoData.CallToAction.Value.LinkCaption

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ func (ac AdCreative) GetLinkCaption() string {`
`298`	`298`	`return ""`
`299`	`299`	`}`
`300`	`300`
`301`		`- if ac.ObjectStorySpec.LinkData != nil {`
	`301`	`+ if ac.ObjectStorySpec.LinkData != nil && ac.ObjectStorySpec.LinkData.CallToAction != nil && ac.ObjectStorySpec.LinkData.CallToAction.Value != nil {`
`302`	`302`	`return ac.ObjectStorySpec.LinkData.CallToAction.Value.LinkCaption`
`303`	`303`	`} else if ac.ObjectStorySpec.VideoData != nil && ac.ObjectStorySpec.VideoData.CallToAction != nil && ac.ObjectStorySpec.VideoData.CallToAction.Value != nil {`
`304`	`304`	`return ac.ObjectStorySpec.VideoData.CallToAction.Value.LinkCaption`