Skip to content

Commit 617c7d1

Browse files
authored
Merge pull request #4 from kravemir/logging
Add logging before resolution of each configuration
2 parents 3bdedba + a8175a4 commit 617c7d1

File tree

2 files changed

+35
-9
lines changed

2 files changed

+35
-9
lines changed

plugin/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ dependencies {
1313
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
1414
}
1515

16-
version = '1.3.0'
16+
version = '1.3.1-SNAPSHOT'
1717
group = 'io.github.jwharm.flatpak-gradle-generator'
1818

1919
java {

plugin/src/main/java/io/github/jwharm/flatpakgradlegenerator/FlatpakGradleGeneratorTask.java

Lines changed: 34 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
import org.gradle.api.artifacts.result.ResolvedDependencyResult;
2727
import org.gradle.api.file.RegularFileProperty;
2828
import org.gradle.api.internal.GradleInternal;
29+
import org.gradle.api.logging.Logger;
30+
import org.gradle.api.logging.Logging;
2931
import org.gradle.api.provider.Property;
3032
import org.gradle.api.tasks.Input;
3133
import org.gradle.api.tasks.OutputFile;
@@ -46,6 +48,8 @@ public abstract class FlatpakGradleGeneratorTask extends DefaultTask {
4648
private static final String DEFAULT_DOWNLOAD_DIRECTORY = "offline-repository";
4749
private static final String GRADLE_PLUGIN_PORTAL = "https://plugins.gradle.org/m2/";
4850

51+
private static final Logger LOGGER = Logging.getLogger(FlatpakGradleGeneratorTask.class);
52+
4953
/**
5054
* Specifies where to write the resulting json file.
5155
*
@@ -83,7 +87,11 @@ public void apply() throws NoSuchAlgorithmException, IOException {
8387
Project project = getProject();
8488

8589
// Buildscript classpath dependencies
86-
var buildScriptRepositories = listPluginRepositories(project);
90+
var buildScriptRepositories = filterRepositories(listPluginRepositories(project));
91+
LOGGER.info(
92+
"Resolving buildscript dependencies using repositories: {}",
93+
buildScriptRepositories
94+
);
8795
for (var configuration : project.getBuildscript().getConfigurations()) {
8896
if (configuration.isCanBeResolved()) {
8997
generateSourcesList(buildScriptRepositories, configuration);
@@ -94,9 +102,14 @@ public void apply() throws NoSuchAlgorithmException, IOException {
94102
// repositories too
95103
var repositories = listRepositories(project);
96104
repositories.addAll(buildScriptRepositories);
105+
repositories = filterRepositories(repositories);
97106

98107
// Loop through configurations and generate json blocks for the
99108
// resolved dependencies
109+
LOGGER.info(
110+
"Resolving project dependencies using repositories: {}",
111+
repositories
112+
);
100113
for (var configuration : project.getConfigurations()) {
101114
if (configuration.isCanBeResolved()) {
102115
generateSourcesList(repositories, configuration);
@@ -153,6 +166,15 @@ private List<String> listPluginRepositories(Project project) {
153166
return urls;
154167
}
155168

169+
private List<String> filterRepositories(List<String> repositories) {
170+
// skip duplicates & local repositories
171+
return repositories
172+
.stream()
173+
.distinct()
174+
.filter(repository -> !repository.startsWith("file:/"))
175+
.toList();
176+
}
177+
156178
/**
157179
* Generate json blocks for all dependencies in the provided configuration.
158180
*
@@ -165,7 +187,15 @@ private void generateSourcesList(List<String> repositories,
165187
Configuration configuration)
166188
throws IOException, NoSuchAlgorithmException {
167189

168-
for (var dependency : listDependencies(configuration)) {
190+
var dependencies = listDependencies(configuration);
191+
192+
LOGGER.info(
193+
"Resolving configuration {} with {} dependencies",
194+
configuration.getName(),
195+
dependencies.size()
196+
);
197+
198+
for (var dependency : dependencies) {
169199

170200
String id = dependency.getSelected().getId().getDisplayName();
171201
String variant = dependency.getResolvedVariant().getDisplayName();
@@ -177,12 +207,8 @@ private void generateSourcesList(List<String> repositories,
177207
// Build simple helper object with the Maven coordinates of the artifact
178208
var dep = DependencyDetails.of(id);
179209

180-
// Loop through the repositories, skip duplicates
181-
for (var repository : repositories.stream().distinct().toList()) {
182-
183-
// Skip local repositories
184-
if (repository.startsWith("file:/"))
185-
continue;
210+
// Loop through the repositories
211+
for (var repository : repositories) {
186212

187213
// Check for a Gradle module artifact
188214
var module = resolver.tryResolve(dep, repository, dep.filename("module"));

0 commit comments

Comments
 (0)