Skip to content

Commit

Permalink
Merge pull request #99 from jwilling/override-init-layout
Browse files Browse the repository at this point in the history
Fix layout initializers
  • Loading branch information
jwilling committed Jan 26, 2014
2 parents 67ad7af + 61bcb58 commit ff014de
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions JNWCollectionView/JNWCollectionViewGridLayout.m
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ @interface JNWCollectionViewGridLayout()

@implementation JNWCollectionViewGridLayout

- (instancetype)initWithCollectionView:(JNWCollectionView *)collectionView {
self = [super initWithCollectionView:collectionView];
- (instancetype)init {
self = [super init];
if (self == nil) return nil;
self.itemSize = JNWCollectionViewGridLayoutDefaultSize;
return self;
Expand Down
4 changes: 2 additions & 2 deletions JNWCollectionView/JNWCollectionViewListLayout.m
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ @interface JNWCollectionViewListLayout()

@implementation JNWCollectionViewListLayout

- (instancetype)initWithCollectionView:(JNWCollectionView *)collectionView {
self = [super initWithCollectionView:collectionView];
- (instancetype)init {
self = [super init];
if (self == nil) return nil;
self.rowHeight = 44.f;
return self;
Expand Down
4 changes: 2 additions & 2 deletions JNWCollectionViewTests/JNWCollectionViewSpec.m
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

beforeAll(^{
collectionView = [[JNWCollectionView alloc] initWithFrame:CGRectMake(0, 0, 400, 400)];
collectionViewLayout = [[JNWCollectionViewLayout alloc] initWithCollectionView:collectionView];
collectionViewLayout = [[JNWCollectionViewLayout alloc] init];
collectionView.collectionViewLayout = collectionViewLayout;
testDataSource = [[JNWTestDataSource alloc] init];
collectionView.dataSource = testDataSource;
Expand Down Expand Up @@ -82,7 +82,7 @@

beforeAll(^{
collectionView = [[JNWCollectionView alloc] initWithFrame:CGRectMake(0, 0, 300, 500)];
collectionViewLayout = [[JNWCollectionViewLayout alloc] initWithCollectionView:collectionView];
collectionViewLayout = [[JNWCollectionViewLayout alloc] init];
collectionView.collectionViewLayout = collectionViewLayout;
dataSource = [[JNWTestDataSource alloc] init];
collectionView.dataSource = dataSource;
Expand Down
2 changes: 1 addition & 1 deletion JNWCollectionViewTests/JNWTestImplementation.m
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ - (NSInteger)numberOfSectionsInCollectionView:(JNWCollectionView *)collectionVie
}

- (JNWCollectionViewReusableView *)collectionView:(JNWCollectionView *)collectionView viewForSupplementaryViewOfKind:(NSString *)kind inSection:(NSInteger)section {
if ([kind isEqualToString:JNWCollectionViewListLayoutHeaderIdentifier]) {
if ([kind isEqualToString:JNWCollectionViewListLayoutHeaderKind]) {
JNWCollectionViewReusableView *header = [collectionView dequeueReusableSupplementaryViewOfKind:kind withReuseIdentifer:kTestDataSourceHeaderIdentifier];
return header;
} else {
Expand Down

0 comments on commit ff014de

Please sign in to comment.