Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nftables support #44

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

galal-hussein
Copy link
Contributor

@galal-hussein galal-hussein commented Feb 7, 2023

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein galal-hussein marked this pull request as ready for review February 8, 2023 21:29
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably set bin_dir at the top of the file instead of right before calling the functions, just for readability's sake.

Also, one of the set functions still uses the wrong variable.

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein
Copy link
Contributor Author

I would probably set bin_dir at the top of the file instead of right before calling the functions, just for readability's sake.

Also, one of the set functions still uses the wrong variable.

yeah sorry the file was saved incorrectly, I fixed it now

@galal-hussein galal-hussein merged commit a5419ae into k3s-io:master Mar 27, 2023
@brandond brandond mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants