Remove unnecessary loop variable copies (elastic#6997)

.golangci.yml

@@ -46,7 +46,7 @@ linters:
     - asciicheck # simple linter to check that your code does not contain non-ASCII identifiers
     - bodyclose # checks whether HTTP response body is closed successfully
     - durationcheck # check for two durations multiplied together
-    - exportloopref # checks for pointers to enclosing loop variables
+    - copyloopvar # checks for unnecessary loop variable copies
     - goimports # Goimports does everything that gofmt does. Additionally it checks unused imports
     - gosec # inspects source code for security problems
     - importas # enforces consistent import aliases

internal/pkg/agent/application/monitoring/processes_cloud_test.go

@@ -90,7 +90,6 @@ func TestExpectedCloudProcessID(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		tc := tc // make a copy to avoid implicit memory aliasing
 		t.Run(tc.name, func(t *testing.T) {
 			assert.Equal(t, tc.id, expectedCloudProcessID(&tc.component))
 		})
@@ -143,7 +142,6 @@ func TestMatchesCloudProcessID(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		tc := tc // make a copy to avoid implicit memory aliasing
 		t.Run(tc.name, func(t *testing.T) {
 			assert.Equal(t, tc.matches, matchesCloudProcessID(&tc.component, tc.processID))
 		})

internal/pkg/eql/eql_test.go

@@ -380,7 +380,6 @@ func TestEql(t *testing.T) {
 	}
 
 	for _, test := range testcases {
-		test := test
 		var title string
 		if test.err {
 			title = fmt.Sprintf("%s failed parsing", test.expression)

internal/pkg/otel/configtranslate/otelconfig.go

@@ -77,7 +77,6 @@ func getSupportedComponents(model *component.Model) []*component.Component {
 	var supportedComponents []*component.Component
 
 	for _, comp := range model.Components {
-		comp := comp
 		if IsComponentOtelSupported(&comp) {
 			supportedComponents = append(supportedComponents, &comp)
 		}

testing/fleetservertest/server.go

@@ -110,7 +110,6 @@ func NewRouter(handlers *Handlers) *mux.Router {
 
 	router := mux.NewRouter().StrictSlash(true)
 	for _, route := range handlers.Routes() {
-		route := route // needed because it's been captured in the closure
 		router.
 			Methods(route.Method).
 			Path(route.Pattern).
@@ -514,7 +513,7 @@ func (s *statusResponseWriter) Header() http.Header {
 
 func (s *statusResponseWriter) Write(bs []byte) (int, error) {
 	n, err := s.w.Write(bs)
-	s.byteCount.Add(uint64(n))
+	s.byteCount.Add(uint64(n)) //nolint:gosec// output of Write is guaranteed to be non-negative
 	return n, err
 }