Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kudo-matic S3 buckets and IAM user #80

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

JoostSaanen
Copy link
Member

What

Added AWS S3 buckets (kudo-o-matic-production, kudo-o-matic-development, kudo-o-matic-staging) and an IAM user with appropriate permissions using Terraform.

Why

Managing S3 buckets and IAM access via Terraform ensures consistency, security, and easier maintenance within the project. This setup allows controlled access to the storage resources needed by Kudo-o-Matic.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

@JoostSaanen JoostSaanen requested a review from pascalw March 1, 2025 14:58
@lukvdborne
Copy link
Contributor

Hey @JoostSaanen / @pascalw, ik mis nog even de IAM creds. Zal ik kijken of ik die toe kan voegen en kan importeren?

@JoostSaanen JoostSaanen requested a review from lukvdborne March 3, 2025 15:41
@JoostSaanen
Copy link
Member Author

Hey @JoostSaanen / @pascalw, ik mis nog even de IAM creds. Zal ik kijken of ik die toe kan voegen en kan importeren?

Ja die heb ik aangemaakt via de console en toegevoegd aan Heroku

policy_arn = aws_iam_policy.kudo_policy.arn
}

resource "aws_iam_access_key" "kudo_user_iam_access_key" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoostSaanen heb hier ook nog de key toegevoegd.

Copy link
Contributor

@lukvdborne lukvdborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoostSaanen JoostSaanen merged commit b4584af into develop Mar 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants