Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of permission attributes: All permission related attributes should be optional #436

Closed
ryzheboka opened this issue Jan 17, 2025 · 0 comments · Fixed by #444
Closed

Fix handling of permission attributes: All permission related attributes should be optional #436

ryzheboka opened this issue Jan 17, 2025 · 0 comments · Fixed by #444
Labels
bug Something isn't working

Comments

@ryzheboka
Copy link
Contributor

All permission related attributes should be optional. However, right now, Kadai isn't working without some of the permission attributes.
@ryzheboka ryzheboka added the bug Something isn't working label Jan 17, 2025
@bruderj15 bruderj15 self-assigned this Jan 20, 2025
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Jan 20, 2025
@bruderj15
kadai-io#436: optional permission ldap props
9affdc2
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Jan 20, 2025
@bruderj15
kadai-io#436: fix test testLdap_checkForMissingConfigurations
74a1c5b
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Jan 20, 2025
@bruderj15
kadai-io#436: apply code-style
5837ee5
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Jan 20, 2025
@bruderj15
Revert "kadai-io#436: apply code-style"
1d6add3 
This reverts commit 5837ee5.
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Jan 20, 2025
@bruderj15
kadai-io#436: apply KADAI check-style
98aa11f
@bruderj15 bruderj15 removed their assignment Jan 20, 2025
@bruderj15 bruderj15 mentioned this issue Jan 20, 2025
Merged
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Jan 20, 2025
@bruderj15
kadai-io#436: refresh yarn.lock
f05ccbc
@bruderj15 bruderj15 linked a pull request Jan 28, 2025 that will close this issue
Closes #436 - fix mistakenly required ldap-permission-props to be optional #444
Merged
7 tasks
bruderj15 added a commit that referenced this issue Feb 6, 2025
@bruderj15
Closes #436 - fix mistakenly required ldap-permission-props to be opt…
dcc80e6 
…ional
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Feb 11, 2025
@bruderj15
kadai-io#436: apply code-style
764fd57
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Feb 11, 2025
@bruderj15
Revert "kadai-io#436: apply code-style"
835a30a 
This reverts commit 5837ee5.
bruderj15 added a commit to bruderj15/kadai-fork that referenced this issue Feb 11, 2025
@bruderj15
kadai-io#436: apply KADAI check-style
46cec75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #436 - fix mistakenly required ldap-permission-props to be optional bruderj15/kadai-fork
2 participants
@ryzheboka @bruderj15