Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test KadaiEngine with different ConnectionManagementModes #512

Open
bruderj15 opened this issue Jan 31, 2025 · 3 comments · May be fixed by #530
Open

Test KadaiEngine with different ConnectionManagementModes #512

bruderj15 opened this issue Jan 31, 2025 · 3 comments · May be fixed by #530
Assignees

Comments

@bruderj15
Copy link
Member

Following #44 and the discussion in #491 (comment), revisit the old Taskana-Tests, transfer those worth to Kadai and extend where necessary.

@bruderj15
Copy link
Member Author

The related PR: Taskana/taskana#1383

@bruderj15
Copy link
Member Author

Seems like they tested the modes for each Service-Implementation separately:

I think we can do better.
Possibly by using @TestTemplate with some clever Provider-Logic.

@bruderj15
Copy link
Member Author

bruderj15 commented Feb 4, 2025

Possibly by using @TestTemplate with some clever Provider-Logic.

No. That's overkill and doesn't hit the point.

Easiest approach: Take functionality of UserServiceImpl and test with all the different ConnectionManagementModes.
Most isolated approach: Create or leverage (I think I've seen one before) a Test-Mapper and test the modes with it.

Take second if feasible.

EDIT: Yes, such a mapper exists already: TaskTestMapper

@bruderj15 bruderj15 self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant