Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #512 - Test KadaiEngine with different ConnectionManagementModes #530

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

bruderj15
Copy link
Member

@bruderj15 bruderj15 commented Feb 6, 2025

Tests for ConnectionManagementMode=PARTICIPATE are not yet complete.

Thanks for your PR! Please fill out the following list :)


  • I put the ticket or multiple tickets in review
  • Commit message format → Closes #<Issue Number> - Your commit message.
  • Sonarcloud link : <add the link here>
  • No documentation update needed
  • Link to PR with documentation update: <add the link here>
  • No Release Notes needed
  • Release Notes :

@bruderj15
Copy link
Member Author

ConnectionManagementMode=EXPLICIT succeeds with H2 and Postgres but fails with DB2, see CI.

Seems like a bug with DB2.
Having no knowledge about DB2 at all, I cannot find it.

@bruderj15 bruderj15 linked an issue Feb 6, 2025 that may be closed by this pull request
Copy link
Contributor

@CRoberto1926 CRoberto1926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could probably summarize KadaiEngineAutocommitModeTest, KadaiEngineExplicitModeTest and KadaiEngineParticipateModeTest in one KadaiEngineModesTest class, and then group them using @Nested. I think they would be better grouped together.

@bruderj15
Copy link
Member Author

bruderj15 commented Feb 14, 2025

Wondering big time here.
Current failures are:

  • EXPLICIT succeeds with H2 and Postgres but fails with DB2, see CI
  • PARTICIPATE fails completely, see CI

@bruderj15
Copy link
Member Author

@jamesrdi you are familiar with the core, right? What's going wrong here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test KadaiEngine with different ConnectionManagementModes
4 participants