-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #512 - Test KadaiEngine with different ConnectionManagementModes #530
base: master
Are you sure you want to change the base?
Conversation
Seems like a bug with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could probably summarize KadaiEngineAutocommitModeTest
, KadaiEngineExplicitModeTest
and KadaiEngineParticipateModeTest
in one KadaiEngineModesTest
class, and then group them using @Nested
. I think they would be better grouped together.
@jamesrdi you are familiar with the core, right? What's going wrong here? |
Tests for
ConnectionManagementMode
=PARTICIPATE
are not yet complete.Thanks for your PR! Please fill out the following list :)