Partially closes #555 - Partially fix collision between @WithAccessId and @TestTemplate
#578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and `@TestTemplate`
bruderj15
changed the title
@WithAccessId and @T`@WithAccessId and @TestTemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves my use-case in #577 without otheriwse influcencing the semantics and usage of
@WithAccessId.The fix only works for single
@WithAccessIdand is therefore partial.This is a good temporary fix but the whole concept and implementation of
@WithAccessId(s)should be adapted to Container-Templates with junit-team/junit5#871 once they're released - probably very soon.Thanks for your PR! Please fill out the following list :)