-
Notifications
You must be signed in to change notification settings - Fork 63
Skip Notes Instead of Cards #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@landonepps I noticed the add-on on AnkiWeb was recently updated with your fork of Morphman linked for the changeset, where you have pulled this PR. Is this repo of @kaegi's not the official place to submit fixes? Or is your repo simply for 2.1 and this one is for 2.0, and I have missed some documentation. Regardless, good stuff on pulling it in there to the actual add-on 👍 👏 ping the relevant PR/issue for some well deserved kudos next time 😉 |
Yeah, I don't have write access to this repository, so I'm unable to create tags for releases or merge PRs. But for future changes please continue to use kaegi/MorphMan. I don't want things to get fragmented. |
Updated PR to also not skip cards marked as Comprehension if any of the cards in the note have already been studied. This was an oversight on my part, as my previous fix will only stop Morphman from skipping new cards. Just a one liner, and it works well on my system (I have 1000 or so 'Comprehension' cards to catch up with now!) |
I've too only noticed a few days ago and I have about the same number 😅. I'll edit this into my Morphman and see how it goes. |
Great minds |
Fixes #106.
Cards should only be skipped if all the cards on that note are also skipped. If one card is learned, the other cards should be too. See the above issue for examples.
This is a simple fix, that is far from perfect. Though @AtilioA has also tested it, so it does work at least.
Possible Improvements:
This will keep the other cards from falling down into the queue after the morph has been learned. I do not believe I have experienced this, but I can see it is a possibility.
I personally cannot see a reason why someone would want to skip subsequent card types, surely they'd just remove the card type they never study? Though if others want it I could add a togglable option for this.
All feedback welcome 👍