Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass configuration from secret #12

Merged

Conversation

timchenko-a
Copy link
Contributor

Resolves #9
Implementation is similar to yamlApplicationConfigConfigMap approach.
Maybe in the future it will make sense to review the approach a little bit, because right now it's possible to pass simultaneously yamlApplicationConfig, yamlApplicationConfigConfigMap and yamlApplicationConfigSecret, they all will be handled correctly, but only one of them will be actually used as a config file for the application (due to if/else here). IMHO this might be not really obvious.

I suspect I should also upgrade the documentation here?

Tested locally, worked without any issues:

helm ls
NAME    	NAMESPACE	REVISION	UPDATED                             	STATUS  	CHART         	APP VERSION
kafka-ui	kafka-ui 	2       	2024-04-19 14:45:11.72722 +0300 EEST	deployed	kafka-ui-1.3.0	v1.0.0

helm get values kafka-ui
USER-SUPPLIED VALUES:
resources:
  limits:
    memory: 512Mi
  requests:
    cpu: 200m
    memory: 512Mi
yamlApplicationConfigSecret:
  keyName: config.yaml
  name: kafka-ui-config

Application is also working and reachable.

@timchenko-a timchenko-a requested a review from a team as a code owner April 19, 2024 12:08
@Haarolean Haarolean added the type/enhancement En enhancement/improvement to an already existing feature label Apr 20, 2024
@timchenko-a timchenko-a force-pushed the feature-9-add-yamlApplicationConfigSecret branch from 1012d99 to e1d8051 Compare April 20, 2024 20:16
Copy link
Member

@azatsafin azatsafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your proposal and efforts

@Haarolean Haarolean merged commit 42a9113 into kafbat:main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to pass config via secret
3 participants