Add ability to pass configuration from secret #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9
Implementation is similar to
yamlApplicationConfigConfigMap
approach.Maybe in the future it will make sense to review the approach a little bit, because right now it's possible to pass simultaneously
yamlApplicationConfig
,yamlApplicationConfigConfigMap
andyamlApplicationConfigSecret
, they all will be handled correctly, but only one of them will be actually used as a config file for the application (due to if/else here). IMHO this might be not really obvious.I suspect I should also upgrade the documentation here?
Tested locally, worked without any issues:
Application is also working and reachable.