Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly 9 #206

Merged
merged 10 commits into from
Nov 10, 2024
Merged

Weekly 9 #206

merged 10 commits into from
Nov 10, 2024

Conversation

hjinshin
Copy link
Contributor

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

์ด๋ฏธ์ง€ ์ฒจ๋ถ€

To Reviewers ๐Ÿ“ข

์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ๋ฅผ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค.
  • API ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • API ํ˜ธ์ถœ์„ ์ง์ ‘ ์‹ค์‹œํ•˜์˜€๊ณ , ํ•ด๋‹น ๋ฐ์ดํ„ฐ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ๋Š” ์ž‘์—… ๋‚ด์šฉ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ถ”๊ฐ€์ ์ธ ์ž‘์—…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ด€๋ จ ์ด์Šˆ

  • close #

yso8296 and others added 10 commits November 8, 2024 23:47
* Feat: RedissonConfig ์„ค์ •

* Feat: Redisson Lock ๊ตฌํ˜„(์ž„์‹œ)

* Fix: RaceCondition ํ…Œ์ŠคํŠธ ์˜ค๋ฅ˜ ์ˆ˜์ •

1. RedissonLock์˜ value๋กœ hostId๋งŒ ๋„˜๊ธฐ๊ธฐ
2. RaceConditionTest๋ฅผ SpringBootTest๋กœ ํ…Œ์ŠคํŠธ
3. BeforeEach๋กœ Redis ์ดˆ๊ธฐํ™”

* Refactor: GroupMember ์กฐํšŒ fetch join ์ ์šฉ

* Refactor: random GroupMember ์กฐํšŒ fetch join ์ ์šฉ

* Refactor: ๋ฐฉ๋ฌธ์ž ์กฐํšŒ์ˆ˜ ๋น„๋™๊ธฐ ๋กœ์ง ์ถ”๊ฐ€

* Feat: ์งˆ๋ฌธ ์ง€๋ชฉ ์‹œ count ์ฆ๊ฐ€ ๋™์‹œ์„ฑ ์ œ์–ด

* Refactor: merge weekly9

* Refactor: ๋ˆ„๋ฝ๋œ ์ฝ”๋“œ ์ถ”๊ฐ€

* Refactor: ๋ˆ„๋ฝ๋œ ์ฝ”๋“œ ์ถ”๊ฐ€

* Refactor: ์ฝ”๋“œ ์ˆ˜์ •

* Refactor: redissonClient ์ œ๊ฑฐ

* Refactor: redis ์„ค์ • ๋ณ€๊ฒฝ

* Refactor: redis ์„ค์ • ๋ณ€๊ฒฝ

* HotFix: ์ด๋ฏธ์ง€ ํŒŒ์ผ resize ๋น„์œจ ์กฐ์ •

* Refactor: RedissonClient ์‚ฌ์šฉ ํ…Œ์ŠคํŠธ ActiveProfile ์„ค์ •

* Refactor: RedissonClient ์‚ฌ์šฉ ํ…Œ์ŠคํŠธ Profile ์„ค์ •

* Fix: Profile() ๋ฉ”์„œ๋“œ์— ์ ์šฉ

* Fix: ProfileIntegrationTest, RaceConditionTest ์ฃผ์„์ฒ˜๋ฆฌ

* Fix: ์ถฉ๋Œ ํ•ด๊ฒฐ

* Refactor: Random Question Response ์ˆ˜์ •

* Chore: ๋ถˆํ•„์š”ํ•œ Import ์ œ๊ฑฐ

* Import: ์ถฉ๋Œ ํ•ด๊ฒฐ

---------

Co-authored-by: hjinshin <gudwls818@gmail.com>
Co-authored-by: Kwon Da woon <82216606+momnpa333@users.noreply.github.com>
# Conflicts:
#	src/main/java/supernova/whokie/alarm/constants/AlarmConstants.java
Copy link

Unit Test Results

58 testsโ€‚โ€ƒโ€ƒ58 โœ”๏ธโ€ƒโ€ƒ47s โฑ๏ธ
26 suitesโ€ƒโ€ƒโŸโ€„0 ๐Ÿ’ค
26 filesโ€„โ€‚โ€ƒโ€ƒโŸโ€„0 โŒ

Results for commit edafc68.

@hjinshin hjinshin merged commit a66c17f into Develop Nov 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants