Skip to content

design:Add component certificate identification for client components #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

tiansuo114
Copy link
Contributor

What type of PR is this?
/kind design

What this PR does / why we need it:
This pr is about issue#6091

Previously, all Karmada components shared a set of similar certificates. In this case, we cannot identify the request source by the certificate used in the request, which may lead to some ambiguities. This PR aims to propose a design for testing purposes so that once we confirm there are no issues with the implementation, we can synchronize it to the deployment methods used in production environments, such as in karmadactl and karmada-operator.

Which issue(s) this PR fixes:
Fixes #6091

Special notes for your reviewer:
@XiShanYongYe-Chang
@zhzhuang-zju

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/design Categorizes issue or PR as related to design. label Mar 31, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign whitewindmills for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.94%. Comparing base (4c7c15a) to head (5c05f1f).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6246      +/-   ##
==========================================
- Coverage   47.96%   47.94%   -0.02%     
==========================================
  Files         676      676              
  Lines       55974    55971       -3     
==========================================
- Hits        26849    26838      -11     
- Misses      27354    27360       +6     
- Partials     1771     1773       +2     
Flag Coverage Δ
unittests 47.94% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tiansuo114 tiansuo114 force-pushed the sh_test branch 2 times, most recently from 00b7d16 to be4207c Compare April 2, 2025 12:28
and etcd

Signed-off-by: tiansuo <zhaoyi_114@outlook.com>
Signed-off-by: tiansuo <zhaoyi_114@outlook.com>
Signed-off-by: tiansuo <zhaoyi_114@outlook.com>
@tiansuo114 tiansuo114 changed the title Provides the ability to manage related certificates for clusters deployed with the hack/deploy-karmada.sh script in karmada design:Add component certificate identification for client components Apr 7, 2025
@tiansuo114
Copy link
Contributor Author

Due to the community discussion that some of the current modification proposal is not reasonable, the content of this pr is temporarily abandoned, and the part of script changes to the issueare merged into the pr

@tiansuo114 tiansuo114 closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lfx-mentorship-2025-March-May] Karmada Self-Signed Certificate Content Standardization
3 participants