-
Notifications
You must be signed in to change notification settings - Fork 937
design:Add component certificate identification for client components #6246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6246 +/- ##
==========================================
- Coverage 47.96% 47.94% -0.02%
==========================================
Files 676 676
Lines 55974 55971 -3
==========================================
- Hits 26849 26838 -11
- Misses 27354 27360 +6
- Partials 1771 1773 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
00b7d16
to
be4207c
Compare
and etcd Signed-off-by: tiansuo <zhaoyi_114@outlook.com>
Signed-off-by: tiansuo <zhaoyi_114@outlook.com>
Signed-off-by: tiansuo <zhaoyi_114@outlook.com>
What type of PR is this?
/kind design
What this PR does / why we need it:
This pr is about issue#6091
Previously, all Karmada components shared a set of similar certificates. In this case, we cannot identify the request source by the certificate used in the request, which may lead to some ambiguities. This PR aims to propose a design for testing purposes so that once we confirm there are no issues with the implementation, we can synchronize it to the deployment methods used in production environments, such as in
karmadactl
andkarmada-operator
.Which issue(s) this PR fixes:
Fixes #6091
Special notes for your reviewer:
@XiShanYongYe-Chang
@zhzhuang-zju
Does this PR introduce a user-facing change?: