Update is_synced for non-mining context

- Make it not depend on sync rate rule

Author: coderofstuff

protocol/mining/src/rule_engine.rs

@@ -114,6 +114,12 @@ impl MiningRuleEngine {
         is_nearly_synced || self.use_sync_rate_rule.load(std::sync::atomic::Ordering::Relaxed)
     }
 
+    /// In non-mining contexts, we consider the node synced if the sink is recent and it is connected
+    /// to a peer
+    pub fn is_sink_recent_and_connected(&self, sink_daa_score_timestamp: DaaScoreTimestamp) -> bool {
+        return self.has_sufficient_peer_connectivity() && self.is_nearly_synced(sink_daa_score_timestamp);
+    }
+
     /// Returns whether the sink timestamp is recent enough and the node is considered synced or nearly synced.
     ///
     /// This info is used to determine if it's ok to use a block template from this node for mining purposes.

rpc/service/src/service.rs

@@ -480,7 +480,7 @@ NOTE: This error usually indicates an RPC conversion error between the node and
             mempool_size: self.mining_manager.transaction_count_sample(TransactionQuery::TransactionsOnly),
             server_version: version().to_string(),
             is_utxo_indexed: self.config.utxoindex,
-            is_synced: self.mining_rule_engine.should_mine(sink_daa_score_timestamp),
+            is_synced: self.mining_rule_engine.is_sink_recent_and_connected(sink_daa_score_timestamp),
             has_notify_command: true,
             has_message_id: true,
         })
@@ -1145,7 +1145,7 @@ NOTE: This error usually indicates an RPC conversion error between the node and
     ) -> RpcResult<GetServerInfoResponse> {
         let session = self.consensus_manager.consensus().unguarded_session();
         let sink_daa_score_timestamp = session.async_get_sink_daa_score_timestamp().await;
-        let is_synced: bool = self.mining_rule_engine.should_mine(sink_daa_score_timestamp);
+        let is_synced: bool = self.mining_rule_engine.is_sink_recent_and_connected(sink_daa_score_timestamp);
         let virtual_daa_score = session.get_virtual_daa_score();
 
         Ok(GetServerInfoResponse {
@@ -1166,7 +1166,7 @@ NOTE: This error usually indicates an RPC conversion error between the node and
     ) -> RpcResult<GetSyncStatusResponse> {
         let sink_daa_score_timestamp =
             self.consensus_manager.consensus().unguarded_session().async_get_sink_daa_score_timestamp().await;
-        let is_synced: bool = self.mining_rule_engine.should_mine(sink_daa_score_timestamp);
+        let is_synced: bool = self.mining_rule_engine.is_sink_recent_and_connected(sink_daa_score_timestamp);
         Ok(GetSyncStatusResponse { is_synced })
     }