Skip to content

Commit be7c256

Browse files
authored
Merge pull request #407 from Art4/fix-php84-deprecation-warnings
PHP 8.4 Fix implicitly nullable parameter declarations deprecations
2 parents 31768d5 + cc14f15 commit be7c256

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/Redmine/Client/NativeCurlClient.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ final class NativeCurlClient implements Client, HttpClient
3636
public function __construct(
3737
string $url,
3838
string $apikeyOrUsername,
39-
string $password = null
39+
?string $password = null
4040
) {
4141
$this->url = $url;
4242
$this->apikeyOrUsername = $apikeyOrUsername;

src/Redmine/Client/Psr18Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function __construct(
4545
StreamFactoryInterface $streamFactory,
4646
string $url,
4747
string $apikeyOrUsername,
48-
string $password = null
48+
?string $password = null
4949
) {
5050
if (! $requestFactory instanceof RequestFactoryInterface && $requestFactory instanceof ServerRequestFactoryInterface) {
5151
@trigger_error(

src/Redmine/Exception/UnexpectedResponseException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ final class UnexpectedResponseException extends RuntimeException implements Redm
2121
*/
2222
private $response = null;
2323

24-
public static function create(Response $response, Throwable $prev = null): self
24+
public static function create(Response $response, ?Throwable $prev = null): self
2525
{
2626
$e = new self(
2727
'The Redmine server replied with an unexpected response.',

0 commit comments

Comments
 (0)