Skip to content

Fix redundant requests AbstractApi::retrieveData() #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2025

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Jan 21, 2025

Fixes #436.

@Art4 Art4 added this to the v2.8.0 milestone Jan 21, 2025
@Art4 Art4 self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (c94d01b) to head (07b5153).
Report is 5 commits behind head on v2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #440   +/-   ##
=========================================
  Coverage     98.63%   98.63%           
- Complexity      656      659    +3     
=========================================
  Files            29       29           
  Lines          2047     2056    +9     
=========================================
+ Hits           2019     2028    +9     
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Art4 Art4 marked this pull request as ready for review May 24, 2025 20:23
@Art4 Art4 requested a review from kbsali May 24, 2025 20:25
@Art4 Art4 merged commit 5d599d3 into kbsali:v2.x May 27, 2025
13 checks passed
@Art4 Art4 deleted the 436-redundant-request branch May 27, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant request when the limit is more than the nearest multiple of hundred from the total_count
2 participants