Skip to content

WIP - Add support for Go template expressions in PublishedResources #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

WIP - Add support for Go template expressions in PublishedResources #66

wants to merge 13 commits into from

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 22, 2025

Summary

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #46

Release Notes

* Add support for Go templates in various places in a PublishedResource.
* Deprecate `$variable` based naming in favor of Go templates.

@kcp-ci-bot kcp-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. labels May 22, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xrstf. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf xrstf changed the title Add support for Go template expressions in PublishedResources WIP - Add support for Go template expressions in PublishedResources May 22, 2025
@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 22, 2025
@xrstf xrstf mentioned this pull request May 22, 2025
Merged
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 22, 2025
xrstf added 12 commits May 23, 2025 09:39
@xrstf
implement basic templating for PR naming rules
8a0ab33 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
implement support for templated related resource refs
060d425 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
implement templating in label selectors
e7e0fc9 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
implement templating for label-selector based rewrites
3299827 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
lint
7a980ed 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
codegen
4fd0b28 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
bump minimum Go version for the agent to Go 1.24
17d19ce 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
adjust naming tests to new sha3 defaults
22c2d7a 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
use t.Context() in tests
95bde59 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
add unit test for template-based naming
9fbf31d 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
make the current side available to templates to enable complex logic
710bb37 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
finally re-enable the exotic related resources tests
7ca0303 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
Copy link
Contributor Author

xrstf commented May 23, 2025

/retest

@xrstf
add basic test for templated label selectors
46be4fb 
On-behalf-of: @SAP christoph.mewes@sap.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Go Templated expressions
2 participants
@xrstf @kcp-ci-bot