🌱 switch to logicalcluster.v3 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
p0lyn0mial
force-pushed
the
logicalcluster-v3
branch
6 times, most recently
from
a68ecb1 to
028c1ca
Compare
p0lyn0mial
force-pushed
the
logicalcluster-v3
branch
from
028c1ca to
57265fa
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
do we want to create |
p0lyn0mial
force-pushed
the
logicalcluster-v3
branch
from
57265fa to
5bce131
Compare
p0lyn0mial
force-pushed
the
logicalcluster-v3
branch
5 times, most recently
from
9528e11 to
752516d
Compare
Yes |
p0lyn0mial
force-pushed
the
logicalcluster-v3
branch
from
9066e01 to
3c4d914
Compare
p0lyn0mial
force-pushed
the
logicalcluster-v3
branch
from
3c4d914 to
17d4a70
Compare
|
/lgtm |
|
fyi: i'm going to revert 9ebb7f6 once we merge kcp-dev/client-go#20 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches the code-generator repository to use logicalcluster.v3 and also bumps the major version number for this repository to v2 in the go.mod file. That means that users will have to import it as github.com/kcp-dev/code-generator/v2
Related issue(s)
Fixes #