Skip to content

🌱 Fix indexes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

🌱 Fix indexes #10

wants to merge 4 commits into from

Conversation

sttts
Copy link
Member

@sttts sttts commented Mar 16, 2025

Summary

Related issue(s)

Fixes #

Release Notes

NONE

sttts added 4 commits March 16, 2025 18:40
@sttts
Implement Provider.IndexField
e65c11d 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
Add gci for import sorting
b6729c4 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
Add client package
0bfbcd6 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
Add envtest
360a7aa 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Mar 16, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sttts. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 16, 2025
@sttts sttts changed the title 🌱 Add envtest 🌱 Fix indexes Mar 16, 2025
@kcp-ci-bot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-multicluster-provider-verify 360a7aa link true /test pull-multicluster-provider-verify
pull-multicluster-provider-test 360a7aa link true /test pull-multicluster-provider-test
pull-multicluster-provider-lint 360a7aa link true /test pull-multicluster-provider-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2025
@kcp-ci-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Member Author

sttts commented Mar 23, 2025

Merged as part of #14.

@sttts sttts closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sttts @kcp-ci-bot