Skip to content

🌱 test/e2e: test scoped indexes #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

sttts
Copy link
Member

@sttts sttts commented Mar 20, 2025

Summary

Add tests

  1. that do CRUD against the resource schema in its APIExport's virtual workspace
  2. that scoped indexes work.

The former was broken because in the test no thing version was served 🤦‍♂️

The later was broken because the index name was incorrect, and because the key were incorrectly computed.

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2025
@sttts sttts force-pushed the sttts-indexes-test branch from 356ce74 to 6425985 Compare March 20, 2025 20:58
sttts added 2 commits March 20, 2025 22:34
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts sttts force-pushed the sttts-indexes-test branch from 6425985 to dbce2c0 Compare March 20, 2025 21:34
@sttts sttts changed the title 🌱 test/e2e: actually test that we can do CRUD on the resources 🌱 test/e2e: test scoped indexes Mar 20, 2025
@mjudeikis
Copy link

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7edacf7490c8f3ef3a471bafef57db2ab39dd99

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@kcp-ci-bot kcp-ci-bot merged commit 476a75c into kcp-dev:main Mar 21, 2025
10 checks passed
@sttts sttts mentioned this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants