Fix duration handling

bohwaz · bohwaz · commit 66104b4766f6 · 2024-10-22T12:58:36.000Z
FossilOrigin-Name: 535bea69dc4934d38a5d7589158cd7db63db0df3b624551e34ba7f11c78ff4cb
diff --git a/server/inc/Feed.php b/server/inc/Feed.php
@@ -142,8 +142,9 @@ protected function getDuration(?string $str): ?int
 			return null;
 		}
 
-		if (false !== strpos($str, ':')) {
+		if (false !== strpos($str, ':') && ctype_digit(str_replace(':', '', trim($str)))) {
 			$parts = explode(':', $str);
+			$parts = array_map('intval', $parts);
 			$duration = ($parts[2] ?? 0) * 3600 + ($parts[1] ?? 0) * 60 + $parts[0] ?? 0;
 		}
 		else {

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,9 @@ protected function getDuration(?string $str): ?int`
`142`	`142`	`return null;`
`143`	`143`	`}`
`144`	`144`
`145`		`- if (false !== strpos($str, ':')) {`
	`145`	`+ if (false !== strpos($str, ':') && ctype_digit(str_replace(':', '', trim($str)))) {`
`146`	`146`	`$parts = explode(':', $str);`
	`147`	`+ $parts = array_map('intval', $parts);`
`147`	`148`	`$duration = ($parts[2] ?? 0) * 3600 + ($parts[1] ?? 0) * 60 + $parts[0] ?? 0;`
`148`	`149`	`}`
`149`	`150`	`else {`