Skip to content

fix qwen and add qwen3 #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pass-lin opened this issue Apr 29, 2025 · 0 comments
Closed

fix qwen and add qwen3 #2235

pass-lin opened this issue Apr 29, 2025 · 0 comments
Assignees

Comments

@pass-lin
Copy link
Contributor

There are problems with the current implementation of Qwen.
First of all, "tie_word_embeddings" is an optional feature in the Qwen model. However, in the current Qwen model, it is the default option.

Secondly, regarding the implementation of qwen3. qwen3 and qwen2 only have one difference, which is the qk norm. When we add qwen3, do we just need to add a config for qwen2?

I can help solve the above two problems. Do you think it should be solved by the keras-team, or should I submit a new PR to solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants