style: automatic fixes for new ESLint rules

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

Author: kevinoid

combine.js

@@ -58,7 +58,7 @@ export default function combineOpenapi(openapiDocs) {
     }
 
     for (const [pathStr, pathObj] of Object.entries(paths)) {
-      if (hasOwnProperty.call(combinedPaths, pathStr)) {
+      if (Object.hasOwn(combinedPaths, pathStr)) {
         throw new Error(`Duplicate path ${pathStr}`);
       }
 

index.js

@@ -38,7 +38,7 @@ function visit(transformer, method, propName, propValue) {
     return method.call(transformer, propValue);
   } catch (err) {
     handlingException = true;
-    if (!hasOwnProperty.call(err, 'transformPath')) {
+    if (!Object.hasOwn(err, 'transformPath')) {
       err.transformPath = [...transformer.transformPath];
       err.message +=
         ` (while transforming ${toJsonPointer(err.transformPath)})`;
@@ -318,7 +318,7 @@ export default class ProcoreApiDocToOpenApiTransformer {
             parentObjectSchema.properties = parentProperties;
           }
 
-          if (hasOwnProperty.call(parentProperties, name)) {
+          if (Object.hasOwn(parentProperties, name)) {
             throw new Error(`duplicate property ${name} for parameter`);
           }
 
@@ -347,7 +347,7 @@ export default class ProcoreApiDocToOpenApiTransformer {
             parentObjectSchema.patternProperties = patternProperties;
           }
 
-          if (hasOwnProperty.call(patternProperties, pattern)) {
+          if (Object.hasOwn(patternProperties, pattern)) {
             throw new Error(
               `duplicate patternProperty ${pattern} for parameter ${name}`,
             );
@@ -391,7 +391,7 @@ export default class ProcoreApiDocToOpenApiTransformer {
         );
       }
 
-      if (hasOwnProperty.call(propertiesByName, field)) {
+      if (Object.hasOwn(propertiesByName, field)) {
         throw new Error(
           `Duplicate field '${field}' in schema properties`,
         );
@@ -494,7 +494,7 @@ export default class ProcoreApiDocToOpenApiTransformer {
         this.warn('Invalid status:', status);
       }
 
-      if (hasOwnProperty.call(responseByStatus, status)) {
+      if (Object.hasOwn(responseByStatus, status)) {
         throw new Error(`Multiple responses for status ${status}`);
       }
 

lib/doc-bugs-transformer.js

@@ -12,7 +12,7 @@ function applyToPath(transform, obj, propPath, i) {
   }
 
   const propName = propPath[i];
-  if (!hasOwnProperty.call(obj, propName)) {
+  if (!Object.hasOwn(obj, propName)) {
     this.warn('Expected %s on %o', propName, obj);
     return obj;
   }

lib/error-response-transformer.js

@@ -165,13 +165,13 @@ const ubiquitousResponses = {
 
 function isResponseEqual(response1, response2) {
   let response1NoDesc = response1;
-  if (hasOwnProperty.call(response1, 'description')) {
+  if (Object.hasOwn(response1, 'description')) {
     const { description, ...noDesc } = response1;
     response1NoDesc = noDesc;
   }
 
   let response2NoDesc = response2;
-  if (hasOwnProperty.call(response2, 'description')) {
+  if (Object.hasOwn(response2, 'description')) {
     const { description, ...noDesc } = response2;
     response2NoDesc = noDesc;
   }
@@ -182,21 +182,21 @@ function isResponseEqual(response1, response2) {
 function addComponentsResponses(responses) {
   if (responses === undefined) {
     // Deep clone componentsResponses as new components.responses
-    return JSON.parse(JSON.stringify(componentsResponses));
+    return structuredClone(componentsResponses);
   }
 
   // Merge componentsResponses into components.responses
   const newResponses = { ...responses };
   for (const [responseName, response] of Object.keys(componentsResponses)) {
-    if (hasOwnProperty.call(responses, responseName)) {
+    if (Object.hasOwn(responses, responseName)) {
       const oldResponse = responses[responseName];
       if (!isDeepStrictEqual(response, oldResponse)) {
         throw new Error(
           `components.responses.${responseName} already exists`,
         );
       }
     } else {
-      newResponses[responseName] = JSON.parse(JSON.stringify(response));
+      newResponses[responseName] = structuredClone(response);
     }
   }
 

lib/multipart-transformer.js

@@ -173,7 +173,7 @@ export default class MultipartTransformer extends OpenApiTransformerBase {
       return requestBody;
     }
 
-    const schemaMulti = JSON.parse(JSON.stringify(schema));
+    const schemaMulti = structuredClone(schema);
     for (const multipartPropPath of multipartPropPaths) {
       const multipartSchema = get(schema, multipartPropPath, 0);
       if (multipartSchema.type === 'string') {

make-filter.js

@@ -18,7 +18,7 @@ export default function makeEndpointFilter(
   includeBetaPrograms,
 ) {
   const minIndex = supportLevels.indexOf(minSupportLevel);
-  if (minIndex < 0) {
+  if (minIndex === -1) {
     throw new RangeError(`Unrecognized minSupportLevel '${minSupportLevel}'`);
   }
 
@@ -42,7 +42,7 @@ export default function makeEndpointFilter(
     }
 
     const supportIndex = supportLevels.indexOf(supportLevel);
-    if (supportIndex < 0) {
+    if (supportIndex === -1) {
       this.warn('Unrecognized support_level:', supportLevel);
     }